'Split' seems to breakup a string wrong

jeroenpost · Joined: 19 Aug 2014 Posts: 3

I am new in the Bascom and Arduino world.
The project i am working on is an attempt to read GPS data, battery voltage, altitude and motor current from a model airplane and send this data to a laptop.
I came this far:
reading the GPS data from a SW-comport.
making 6,7,8 or 9 strings containing this data.
Adding the measurements current, voltage, altitude / airspeed.
and sending it to a SW-comport to a data sender.

Now something’s simple....add the relevant GPS data.

I want to break up the string with are containing data separated with a ",".
so..split should do the trick.

to show what the problem is…

T_int = Split(r_str(1) , S_str(1) , "," )

Ard(1) = ""
For S_int = 1 To T_int
Ard(1) = Ard(1) + S_str(s_int) + " "
Next

It should break up the string r_str(1) and place the parts separated with "," into an array S_Str().
then put is back together in Ard(1) but the "," should be replaced with spaces.

r_str(1) contains : $GPRMC,202313.00,A,5230.00005,N,00447.12334,E,0.041,,030914,,,A*7A

Ard(1) contains : $GPRMC 202524.00 A 5229.99807 N 00447.1217 4 E 0.054 030914 A*78
(don’t mind the difference in data)
Has anyone any idée why ‘split’ breaks up ,00447.12334,E, into 00447.1233 4 E

(GPS data is dynamic, splitting it up using a separator is the best way... if its works correct..)
See the attachment for the program

(BASCOM-AVR version : 2.0.7.7 )

albertsm · Joined: 09 Apr 2004 Posts: 6197 Location: Holland

Hi Jeroen,

Welcome.

it seems that split() is working correct.
just tried it in the sim:

jeroenpost · Joined: 19 Aug 2014 Posts: 3

Hi Mark,

In your SIM the Longitude is also broken up in two.
This is caused by the size of the target array string.

Read the manual, but don't believe everything they say…
The format of the Longitude should be dddmm.mmmm (10 char) (example:12158.3416)
The GPS send 00447.12334 and that’s 11 char’s
The format of the Latitude should be ddmm.mmmm (9 char) but also contains 1 more.
So…
Dim S_str(20) As String * 10
Should be
Dim S_str(20) As String * 12

Thanks….
Jeroen.

Arera · Joined: 23 Sep 2007 Posts: 386 Location: Wuppertal, Germany

It is always a good idea to dim strings a bit longer than you would expect them to be.
Strings can be (invisibly) terminated by one or two characters, or grow for any other reason. The only disadvantage of dimming them longer is the extra use of ram. If that is no point, dim them long.

jeroenpost · Joined: 19 Aug 2014 Posts: 3

Arera,
I expected split to break of the string to make it fit the target array.
It does but Split puts the remains in the next element of the array.
But you right. I also encountered NULL chars in the source string, so extra space is useful.
I am not happy with a software-UART. It makes the program time critical.
Let’s see if I can use the hardware-UART…
Thanks for the response.

Jeroen.